Don't edit current when changing docks v2 #91168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
force-pushed
the
docks-dont-edit-current-v2
branch
from
03e0cd1
to
5a00b87
Compare
kitbdev
force-pushed
the
docks-dont-edit-current-v2
branch
from
5a00b87
to
eefd311
Compare
KoBeWi
reviewed
Apr 29, 2024
akien-mga
approved these changes
Apr 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the
edit(nullptr)inNOTIFICATION_PREDELETEnot run when exiting, since it doesn't need to clean up anything if exiting.The object was apparently freed but not null, causing a crash on some platforms.
Needs testing on Linux and macOS to make sure #90816 (comment) doesn't happen.
Edit: made sure it works when there is no EditorNode, like in dotnet glue binding.